Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added "Create Relationship" Button to Objects #7034

Open
wants to merge 20 commits into
base: release/6.5.0
Choose a base branch
from
Open

Added "Create Relationship" Button to Objects #7034

wants to merge 20 commits into from

Conversation

Bonsai8863
Copy link
Contributor

Proposed changes

  • Added a "Create Relationship" button to most entity pages (not containers)
  • Replaced speed dial in relationship creation drawers
  • Added resolver to get valid targets for nested ref relationships
  • Nested object drawer only shows valid targets now

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@codecov Codecov
Copy link

codecov bot commented May 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.39%. Comparing base (c4d68ee) to head (c6cc210).
Report is 1 commits behind head on release/6.5.0.

Additional details and impacted files 
@@                Coverage Diff                @@
##           release/6.5.0    #7034      +/-   ##
=================================================
+ Coverage          64.37%   64.39%   +0.02%     
=================================================
  Files                644      644              
  Lines              62137    62157      +20     
  Branches            6890     6898       +8     
=================================================
+ Hits               39998    40028      +30     
+ Misses             22139    22129      -10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SarahBocognano SarahBocognano added the community use to identify PR from community label May 21, 2024
@Bonsai8863 Bonsai8863 force-pushed the feature/fab_replacement/create/relationships branch from d30baf0 to f863b8b Compare May 21, 2024 12:30
@Bonsai8863 Bonsai8863 force-pushed the feature/fab_replacement/create/relationships branch from f863b8b to 714a0db Compare June 6, 2024 15:36
@Bonsai8863 Bonsai8863 force-pushed the feature/fab_replacement/create/relationships branch 3 times, most recently from ab87c9e to 2827bcb Compare June 17, 2024 18:16
@SamuelHassine SamuelHassine force-pushed the master branch 3 times, most recently from b710111 to c15ed81 Compare June 23, 2024 20:06
@Bonsai8863 Bonsai8863 force-pushed the feature/fab_replacement/create/relationships branch 5 times, most recently from a8e30c3 to 3a5fb83 Compare August 6, 2024 14:42
@Bonsai8863 Bonsai8863 force-pushed the feature/fab_replacement/create/relationships branch 4 times, most recently from b1c0107 to 8d1464c Compare August 13, 2024 11:20
@Bonsai8863 Bonsai8863 force-pushed the feature/fab_replacement/create/relationships branch 4 times, most recently from 93f3707 to f9bf6d5 Compare August 21, 2024 19:03
@Bonsai8863 Bonsai8863 force-pushed the feature/fab_replacement/create/relationships branch 2 times, most recently from 9cda64d to 7440b45 Compare September 10, 2024 12:40
@Bonsai8863 Bonsai8863 force-pushed the feature/fab_replacement/create/relationships branch 5 times, most recently from 7315427 to d55f929 Compare September 17, 2024 12:50
@labo-flg labo-flg force-pushed the release/6.5.0 branch 5 times, most recently from 9535c45 to 8574b42 Compare January 17, 2025 16:11
labo-flg and others added 20 commits January 22, 2025 10:41
@labo-flg @Archidoit
[frontend] test release branch CI
6c80d61
@Bonsai8863 @Archidoit
[frontend/backend] FABless Create Relationship button
791c237 
[frontend] WIP: PR feedback being addressed
@Archidoit
[frontend] fix entities creation from Relationship creation panel
76dd1da
@Archidoit
[frontend] code improvements
f7ee00e
@Archidoit
[frontend] fix CreateRelationshipContext state
472e973
@Archidoit
[frontend] fix CreateRelationshipContext state
8049651
@Bonsai8863 @Archidoit
[frontend] Moved bulk relation button to header
37e7329
@Bonsai8863 @Archidoit
[frontend] Reversable relations
d83f940
@Bonsai8863 @Archidoit
[frontend] Create relationship drawer pagination, filters, and loader
33e9efd
@Bonsai8863 @Archidoit
[frontend] Create relationship appears in data table without need to …
4240aa0 
…refresh
@Bonsai8863 @Archidoit
[frontend] Observable bulk relation creation fixed
dff8c05
@Bonsai8863 @Archidoit
[frontend] Reversable relations fix
9c478d6
@Bonsai8863 @Archidoit
[frontend] Related-to relationship fixes
4098932
@Bonsai8863 @Archidoit
[frontend] Drawer button truncated on scroll issue fixed
b40160d
@Bonsai8863 @Archidoit
[frontend] Create relations on observables fixed second stage
97a2a64 
wip searchPaginationOptions passed in but still giving same error

wip still not working

[frontend] wip: recompleted step 1
@Bonsai8863 @Archidoit
[frontend] Nested ref creation on StixDomainObjectNestedEntities working
f1f758b
@Bonsai8863 @Archidoit
[frontend] Nested ref creation on observable knowledge working
bc0d7cf
@Bonsai8863 @Archidoit
[frontend] Defaulted empty list
67a93dc
@Bonsai8863 @Archidoit
[frontend] Fixes to relationship creation
7985ee0
@Archidoit
[frontend] fix label
c6cc210
@Archidoit Archidoit force-pushed the feature/fab_replacement/create/relationships branch from eab4d38 to c6cc210 Compare January 22, 2025 09:41
@Archidoit
Copy link
Member

Creation of relationships with observables from the Overview is broken:

  • Go to a Threat Actor
  • In the Overview tab, click on 'create relationship'
  • Select an observable and continue
  • an error occurs

@Archidoit
Copy link
Member

In an attack pattern, when creating a relationship with an artifact, we can't reverse the relationship anymore

now:
image

before:
image

@Archidoit
Copy link
Member

When I create a relationship of type 'delivers' between an attack pattern and a malware, the relationship is not present in the list (whereas relationship between Attack pattern and malware of type 'uses' are displayed) :
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Archidoit Archidoit

Labels
community use to identify PR from community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Bonsai8863 @Archidoit @SarahBocognano @labo-flg