Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "Create Relationship" Button to Objects #7034

Open
wants to merge 6 commits into
base: release/6.4.0
Choose a base branch
from

Conversation

Bonsai8863
Copy link
Contributor

Proposed changes

  • Added a "Create Relationship" button to most entity pages (not containers)
  • Replaced speed dial in relationship creation drawers
  • Added resolver to get valid targets for nested ref relationships
  • Nested object drawer only shows valid targets now

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.38%. Comparing base (99deaea) to head (eab5db9).
Report is 3 commits behind head on release/6.4.0.

Additional details and impacted files
@@                Coverage Diff                @@
##           release/6.4.0    #7034      +/-   ##
=================================================
+ Coverage          64.33%   64.38%   +0.04%     
=================================================
  Files                608      609       +1     
  Lines              58054    58317     +263     
  Branches            6409     6442      +33     
=================================================
+ Hits               37348    37545     +197     
- Misses             20706    20772      +66     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SarahBocognano SarahBocognano added the community use to identify PR from community label May 21, 2024
@Bonsai8863 Bonsai8863 force-pushed the feature/fab_replacement/create/relationships branch from d30baf0 to f863b8b Compare May 21, 2024 12:30
@Bonsai8863 Bonsai8863 force-pushed the feature/fab_replacement/create/relationships branch from f863b8b to 714a0db Compare June 6, 2024 15:36
@Bonsai8863 Bonsai8863 force-pushed the feature/fab_replacement/create/relationships branch 3 times, most recently from ab87c9e to 2827bcb Compare June 17, 2024 18:16
@Bonsai8863 Bonsai8863 force-pushed the feature/fab_replacement/create/relationships branch 5 times, most recently from a8e30c3 to 3a5fb83 Compare August 6, 2024 14:42
@Bonsai8863 Bonsai8863 force-pushed the feature/fab_replacement/create/relationships branch 4 times, most recently from b1c0107 to 8d1464c Compare August 13, 2024 11:20
@Bonsai8863 Bonsai8863 force-pushed the feature/fab_replacement/create/relationships branch 4 times, most recently from 93f3707 to f9bf6d5 Compare August 21, 2024 19:03
@Bonsai8863 Bonsai8863 force-pushed the feature/fab_replacement/create/relationships branch 2 times, most recently from 9cda64d to 7440b45 Compare September 10, 2024 12:40
@Bonsai8863 Bonsai8863 force-pushed the feature/fab_replacement/create/relationships branch 5 times, most recently from 7315427 to d55f929 Compare September 17, 2024 12:50
@Bonsai8863 Bonsai8863 force-pushed the feature/fab_replacement/create/relationships branch 3 times, most recently from cb69f25 to 8f89a40 Compare October 1, 2024 11:40
@Bonsai8863 Bonsai8863 force-pushed the feature/fab_replacement/create/relationships branch from 8f89a40 to f5a5651 Compare October 3, 2024 08:58
@Archidoit Archidoit self-assigned this Oct 17, 2024
@Bonsai8863 Bonsai8863 force-pushed the feature/fab_replacement/create/relationships branch 3 times, most recently from 0b65dac to b9aaedf Compare October 21, 2024 13:47
@Archidoit
Copy link
Member

When we are in a 'Create a relationship' list, clicking on a line redirects to the entity overview (whereas it should check the box)
image

@Archidoit
Copy link
Member

Archidoit commented Oct 22, 2024

Some styles modification :

  • remove the '+' in the label of these buttons :
    image

image

  • And display these 2 buttons with the secondary color
    image

@Archidoit
Copy link
Member

When you click on the 'create relationship' button from an entity overview, filters are missing in the panel (they should be next to the Search bar) :
image

@Archidoit
Copy link
Member

In the Knowledge tab of an entity > select the Indicator entity type in the right panel. Both the '+' dial and the 'create relationship' button are present :
image

@Archidoit
Copy link
Member

The 'create a relationship' list panel doesn't close after having created a relationship :
image

@Archidoit
Copy link
Member

An error occurs after creating an entity from a 'create a relationship' list panel.

Steps to reproduce:

  • Go to an entity overview
  • Click on the 'create a relationship' button
  • Click on the 'create an entity' button
    image
  • Create an entity
  • Then go elsewhere
  • An error occurs
    image

@Archidoit
Copy link
Member

Archidoit commented Oct 22, 2024

Some relationships types are not allowed (because should be the reverse relation) :
image

@Bonsai8863 Bonsai8863 force-pushed the feature/fab_replacement/create/relationships branch from b9aaedf to 9f28c3d Compare October 23, 2024 17:59
@Archidoit Archidoit changed the base branch from master to release/6.4.0 October 30, 2024 10:49
@Archidoit Archidoit force-pushed the feature/fab_replacement/create/relationships branch from 9f28c3d to 67fe32b Compare November 4, 2024 14:44
@Archidoit
Copy link
Member

An error occurs after creating an entity from a 'create a relationship' list panel.

Steps to reproduce:

  • Go to an entity overview
  • Click on the 'create a relationship' button
  • Click on the 'create an entity' button
    image
  • Create an entity
  • Then go elsewhere
  • An error occurs
    image

fixed

@Archidoit
Copy link
Member

Archidoit commented Nov 6, 2024

It's not possible to reverse relationships anymore :

Exemple between a Malware and an Artifact:
image

Whereas we should have:
image

@Archidoit
Copy link
Member

Archidoit commented Nov 6, 2024

Some UI modifications to do in the 'Create a relationship' panel :
image

  • 'create relations in bulk' and 'create an observable' buttons should have the same height
  • put the 3 buttons 'create an entity', 'create an observable', 'create relations in bulk' at the same level (next to the 'create a relationship' title)
  • the 'create relations in bulk' button should be in primary color
  • write 'create entity' and 'create observable' instead of 'create an entity' and 'create an observable' (to reduce the buttons length)

@Archidoit Archidoit force-pushed the feature/fab_replacement/create/relationships branch from 67fe32b to bf1a7b6 Compare November 6, 2024 11:19
@Archidoit
Copy link
Member

Stix core object types are not well updated in the CreateRelationshipContext.

  • Go to a malware knowledge tab

  • Go to the Campagin section and click on 'create a relationship'
    image

  • Campaigns are displayed in the list

  • Then go to the 'Intrusion set' section and click on 'create a relationship'. It is still campaigns that are displayed in the list :
    image

In the CreateRelationshipContext, we still have stixCoreObjectTypes = 'Campaign' (instead of 'Intrusion-Set')

@Archidoit
Copy link
Member

Stix core object types are not well updated in the CreateRelationshipContext.

  • Go to a malware knowledge tab
  • Go to the Campagin section and click on 'create a relationship'
    image
  • Campaigns are displayed in the list
  • Then go to the 'Intrusion set' section and click on 'create a relationship'. It is still campaigns that are displayed in the list :
    image

In the CreateRelationshipContext, we still have stixCoreObjectTypes = 'Campaign' (instead of 'Intrusion-Set')

FIXED

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community use to identify PR from community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants